Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide/nixos: remove with lib; part 5 #335647

Draft
wants to merge 148 commits into
base: master
Choose a base branch
from

Conversation

Stunkymonkey
Copy link
Contributor

Description of changes

part of #208242

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 18, 2024
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-5 branch 4 times, most recently from 99e4290 to b6d660d Compare August 18, 2024 17:47
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 18, 2024
@philiptaron philiptaron self-requested a review August 19, 2024 19:35
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-5 branch from b6d660d to c3fb945 Compare August 27, 2024 19:46
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 27, 2024
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-5 branch 3 times, most recently from 9d0f3ee to 8e72466 Compare August 28, 2024 18:51
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 28, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-5 branch 3 times, most recently from eabf1bb to 89aa355 Compare September 11, 2024 18:35
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 12, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-5 branch from 89aa355 to 22e80f8 Compare November 23, 2024 17:48
@github-actions github-actions bot added the 6.topic: deepin Desktop environment and its components label Nov 23, 2024
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-5 branch 2 times, most recently from 94861a8 to 1b627fa Compare November 23, 2024 17:56
@Stunkymonkey Stunkymonkey removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 23, 2024
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-5 branch from 1b627fa to 203f700 Compare November 24, 2024 09:07
@philiptaron
Copy link
Contributor

Felix, is this with the new script or old?

@Stunkymonkey
Copy link
Contributor Author

@philiptaron this was done with the new one. But the commit messages are not yet improved...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: deepin Desktop environment and its components 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants