-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide/nixos: remove with lib;
part 5
#335647
Draft
Stunkymonkey
wants to merge
148
commits into
NixOS:master
Choose a base branch
from
Stunkymonkey:treewide-nixos-remove-with-lib-5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
treewide/nixos: remove with lib;
part 5
#335647
Stunkymonkey
wants to merge
148
commits into
NixOS:master
from
Stunkymonkey:treewide-nixos-remove-with-lib-5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
labels
Aug 18, 2024
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-5
branch
4 times, most recently
from
August 18, 2024 17:47
99e4290
to
b6d660d
Compare
ofborg
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
labels
Aug 18, 2024
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-5
branch
from
August 27, 2024 19:46
b6d660d
to
c3fb945
Compare
ofborg
bot
added
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Aug 27, 2024
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-5
branch
3 times, most recently
from
August 28, 2024 18:51
9d0f3ee
to
8e72466
Compare
ofborg
bot
removed
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Aug 28, 2024
wegank
added
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Sep 10, 2024
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-5
branch
3 times, most recently
from
September 11, 2024 18:35
eabf1bb
to
89aa355
Compare
ofborg
bot
removed
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Sep 12, 2024
wegank
added
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Sep 27, 2024
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-5
branch
from
November 23, 2024 17:48
89aa355
to
22e80f8
Compare
github-actions
bot
added
the
6.topic: deepin
Desktop environment and its components
label
Nov 23, 2024
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-5
branch
2 times, most recently
from
November 23, 2024 17:56
94861a8
to
1b627fa
Compare
Stunkymonkey
removed
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Nov 23, 2024
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-5
branch
from
November 24, 2024 09:07
1b627fa
to
203f700
Compare
Felix, is this with the new script or old? |
@philiptaron this was done with the new one. But the commit messages are not yet improved... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: deepin
Desktop environment and its components
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #208242
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.